Messages in this thread | | | Date | Sun, 21 Sep 2003 22:42:37 +0200 | From | Vojtech Pavlik <> | Subject | Re: Broken synaptics mouse.. |
| |
On Sun, Sep 21, 2003 at 10:26:17PM +0200, Peter Osterlund wrote: > Vojtech Pavlik <vojtech@suse.cz> writes: > > > On Sun, Sep 21, 2003 at 09:29:10PM +0200, Peter Osterlund wrote: > > > > > One thing that it doesn't get right is the handling of invalid ABS_* > > > values. How is this supposed to be handled? The driver doesn't know > > > the exact limits for the X/Y values, and discarding values outside > > > some guessed limits will only have the effect that some parts of the > > > touchpad area becomes dead. > > > > I think something like 'if the finger is lifted so much above surface > > that X and Y are unreliable, don't report X and Y'. Is that doable? > > Yes, it should be sufficient to only report X/Y when Z>0. (I thought > invalid values referred to all values outside the limits defined by > dev->absmin and absmax, hence my previous comment.) > > Here is a new patch: > > linux-petero/drivers/input/mouse/synaptics.c | 68 +++++++++++------- > linux-petero/drivers/input/mousedev.c | 100 +++++++++++++++++++-------- > linux-petero/include/linux/input.h | 3 > 3 files changed, 118 insertions(+), 53 deletions(-)
Yes, this now looks very nice. Applied.
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |