lkml.org 
[lkml]   [2003]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.0-test4-mm3
From
Date
On Tue, 2003-09-02 at 01:52, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 01 Sep 2003 22:23:30 +0200, Martin Schlemmer said:
>
> > > + if ! $(DEPMOD) -ae -F System.map $(depmod_opts) $(KERNELRELEASE
> ) ; t=
> > hen \
> > > + echo "*** Depmod failed!!!"; \
> > > + echo "*** You may need to install a current version of
> module-init-to=
> > ols"; \
> > > + echo "*** See http://www.codemonkey.org.uk/post-hallowe
> en-2.5.txt"; \
> > > + exit 1; \
> > > + fi \
> > > + fi
> > > =20
> > > else # CONFIG_MODULES
> >
> > Hmm, this will only work with RH based systems (not using here). I
> > think the best way is how Andrew did it to just warn if depmod fails.
> > You may agree to disagree if need be :)
>
> Umm.. how will this fail for *any* system that has a sane 'depmod' (sane as in
> "calls exit(0) if it worked"? In this patch we never actually check the
> version - we just add code that "if depmod fails during 'make install_modules',
> it may be too old and give them a hint".
>

The problem I have with the patch you had here, is you changed:

DEPMOD = /sbin/depmod

to:

DEPMOD = /sbin/depmod.old

which is only the one from module-init-tools on a RH system ....


Cheers,

--

Martin Schlemmer



[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.081 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site