Messages in this thread | | | Date | Thu, 18 Sep 2003 17:04:56 +0100 | From | Jamie Lokier <> | Subject | Re: [PATCH] Athlon/Opteron Prefetch Fix for 2.6.0test5 + numbers |
| |
Jamie Lokier wrote: > > + /* Don't check for LDT code segments because they could have > > + non zero bases. Better would be to add in the base in this case. */ > > + if (regs->xcs & (1<<2)) > > + return 0; > > It is possible to have a non-standard code segment in the GDT, too. > Thus a better to check is "unlikely((regs->xcs & 0xffff) != __USER_CS)".
Ignore me here, I'm being dense - forgetting about __KERNEL_CS :)
My point is simply that non-zero base GDT segments are possible in userspace, and whatever code you add later to add the base should be aware of that.
-- Jamie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |