Messages in this thread | | | Date | Wed, 10 Sep 2003 21:10:39 +0200 | From | Adrian Bunk <> | Subject | Re: [patch] 2.6.0-test5: serio config broken? |
| |
On Wed, Sep 10, 2003 at 11:59:02AM -0700, Tom Rini wrote: > > > > That wouldn't be needed. AFAIK there are _no_ problems if SERIO=y, the > > select you suggest is already implemented the other way round. > > The problem is that SERIO==y means that SERIO_I8042 must be Y, as you > ran into. If you have SERIO only asked on EMBEDDED || !X86, and on > similar conditions you then select SERIO_I8042, it just works.
No the problems occur when SERIO=m.
> > If SERIO is always y if !EMBEDDED || X86 my patch wouldn't be needed. > > Correct. I was suggesting that you do: > tristate "Serial i/o support (needed for keyboard and mouse)" if > !EMBEDDED || !X86 (or so) > select SERIO_I8042 if X86 && !EMBEDDED > > and then remove the conditions on SERIO_I8042, which puts all of the > auto-select-this magic in one spot.
I can't see how this should work in all cases. Could you send how you'd like to formulate this?
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |