Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 10 Sep 2003 19:14:37 +0200 (MEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] fix type mismatch in jffs. |
| |
On Wed, 10 Sep 2003 viro@parcelfarce.linux.theplanet.co.uk wrote: > On Tue, Sep 09, 2003 at 02:44:20PM -0700, Stephen Hemminger wrote: > > On 2.6.0-test5 jffs generates a warning about type mismatch because it casting a short > > to a pointer. Look like an obvious typo. > > Which it is. Thanks for spotting. Linux, please apply. > > > Builds clean, not tested on real hardware. > > > > diff -Nru a/fs/jffs/inode-v23.c b/fs/jffs/inode-v23.c > > --- a/fs/jffs/inode-v23.c Tue Sep 9 14:41:53 2003 > > +++ b/fs/jffs/inode-v23.c Tue Sep 9 14:41:53 2003 > > @@ -1734,7 +1734,7 @@ > > the device should be read from the flash memory and then > > added to the inode's i_rdev member. */ > > u16 val; > > - jffs_read_data(f, (char *)val, 0, 2); > > + jffs_read_data(f, (char *)&val, 0, 2); > > init_special_inode(inode, inode->i_mode, > > old_decode_dev(val)); > > }
Is this endian-safe?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |