Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 7 Aug 2003 16:55:19 +0100 | From | Russell King <> | Subject | Re: [patch] v4l: sysfs'ify videodev |
| |
On Thu, Aug 07, 2003 at 05:43:42PM +0200, Gerd Knorr wrote: > +static void video_release(struct class_device *cd) > +{ > + struct video_device *vfd = container_of(cd, struct video_device, class_dev); > > -static struct proc_dir_entry *video_dev_proc_entry = NULL; > -struct proc_dir_entry *video_proc_entry = NULL; > -EXPORT_SYMBOL(video_proc_entry); > -LIST_HEAD(videodev_proc_list); > +#if 1 /* needed until all drivers are fixed */ > + if (!vfd->release) > + return; > +#endif > + vfd->release(vfd); > +}
Ok, so you're allowing the release to happen elsewhere. How are you ensuring that the code which vfd->release points to hasn't been unloaded before the video device has been released, or, even, how are you preventing the module containing the above code being removed before all video devices have been released?
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |