Messages in this thread | | | Date | Mon, 4 Aug 2003 23:10:26 -0700 | From | Andrew Morton <> | Subject | Re: i_blksize |
| |
Andries Brouwer <aebr@win.tue.nl> wrote: > > You propose to remove i_blksize. > Yes, a good plan, half an hour's work. > It is used in stat only, so we have to produce some value for stat. > Do you want to replace > inode->i_blksize > by > inode->i_sb->s_optimal_io_size > ?
No, that's different. You are referring to stat.st_blksize. That is a different animal, and we can leave that alone.
inode->i_blksize is equal to (1 << inode->i_blkbits) always, all the time. It is just duplicated nonsense and usually leads to poorer code - multiplications instead of shifts.
It should be a pretty easy incremental set of patches to ease i_blksize out of the kernel.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |