lkml.org 
[lkml]   [2003]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.0-test4-mm3.1 oops with ext3 extended attributes on R/O filesystem
From
Date
On Sat, 30 Aug 2003 21:47:51 PDT, Andrew Morton said:

> Thanks. It's a very straightforward bug; I'll fix it with the below patch.

Fix tested in -test4-mm4, program gets a proper '-EROFS', no signs of hanging
locks. Looks good from here, please push to appropriate maintainers..

> A wider question is whether we should have got this far into the filesystem
> code if the fs is mounted read-only. A check right up at the VFS
> setxattr() level might make sense.

Yes, I was a bit surprised at that as well...

> Regardless of that, this fix is needed because journal_start() could fail
> for other reasons.

Good point, and one I hadn't considered...
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.028 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site