Messages in this thread | | | Date | Thu, 28 Aug 2003 20:18:19 +0200 | From | Mikael Pettersson <> | Subject | Re: [PATCH] bad definition of cpus_complement |
| |
Joe Korty writes: > One of the definitions of cpus_complement is broke. Also, cpus_complement is > the only cpus_* definition which operates in-place rather than in (dst,src) > form. I will submit a patch to convert if there is interest. > > Joe > > --- include/asm-generic/cpumask_up.h.orig 2003-08-27 06:08:38.000000000 -0400 > +++ include/asm-generic/cpumask_up.h 2003-08-28 11:45:09.000000000 -0400 > @@ -28,7 +28,7 @@ > > #define cpus_complement(map) \ > do { \ > - cpus_coerce(map) = !cpus_coerce(map); \ > + cpus_coerce(map) = ~cpus_coerce(map); \ > } while (0)
Broken how? The value range for a cpumask_t on UP is [0,1], and ! respects that whereas ~ does not. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |