Messages in this thread | | | From | Andrew Theurer <> | Subject | Re: [patch 2.6.0t4] 1 cpu/node scheduler fix | Date | Mon, 25 Aug 2003 10:54:36 -0500 |
| |
> This simple patch is not meant as opposition to Andrew's attempt to > NUMAize the whole scheduler. That one will definitely make NUMA > coders' lives easier but I fear that it is a bit too complex for > 2.6.
I would agree, it's probably too much to change this late in 2.6. Eventually (2.7) I think we should revisit this and try for a more unified approach.
> The attached small incremental change is sufficient to solve the > main problem. Besides, the change of the cross-node scheduling is > compatible with Andrew's scheduler structure. I really don't like the > timer-based cross-node balancing because it is too unflexible (no way > to have different balancing intervals for each node) and I'd really > like to get back to just one single point of entry for load balancing: > the routine load_balance(), no matter whether we balance inside a > timer interrupt or while the CPU is going idle.
Looks good to me. One other thing your patch fixes: Once in a while we called load_balance in rebalance_tick with the wrong 'idle' value. Occasionally we would be on an idle_node and idle_cpu rebalance tick, the idle cpu would [possibly] pull a task, become non-idle, then we would call load_balance again, but still have idle=1 for the intranode balance.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |