Messages in this thread | | | Subject | Re: [PATCH] RFC: kills consistent_dma_mask | From | Jes Sorensen <> | Date | 19 Aug 2003 09:20:34 -0400 |
| |
>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
Alan> On Maw, 2003-08-19 at 10:03, Jes Sorensen wrote: >> That would be totally messy. Having drivers do the accounting of >> what mask is currently set and have them switch back and forth >> depending on what type of allocation is currently being used would >> be a nightmare to debug.
Alan> It is messy, but the consistent mask only helps a small subset Alan> of cases. Having an __pci_alloc_foo that took the mask as an Alan> argument is (a) trivial (b) adds almost no code (c) solves the Alan> general case problem.
And d) puts the accounting back into the drivers in duplicate. So far we have managed pretty well with the distinction between consistent and dynamic, but sure if there is hardware out there where it makes sense to have a more generic interface we should consider it.
Jes
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |