Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Aug 2003 16:20:23 -0400 (EDT) | From | Zwane Mwaikambo <> | Subject | RE: Update MSI Patches |
| |
On Mon, 18 Aug 2003, long wrote:
> I make minor modification to the last patch to reduce some duplicate functions, > as shown as below. I think this perhaps looks better. What do you think?
The patch looks fine.
> +#ifdef CONFIG_PCI_USE_VECTOR > +static unsigned int startup_edge_ioapic_vector(unsigned int vector) > +{ > + int irq = vector_to_irq(vector); > + > + return (startup_edge_ioapic_irq(irq)); > +}
Tiny nit, Linux coding style is;
return startup_edge_ioapic_irq(irq);
But you can queue that change for later. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |