Messages in this thread | | | Date | Thu, 14 Aug 2003 10:18:17 -0500 | From | Eli Carter <> | Subject | Re: [PATCH] CodingStyle fixes for drm_agpsupport |
| |
Larry McVoy wrote: > On Thu, Aug 14, 2003 at 09:21:44AM -0500, Eli Carter wrote: > >>>That ought to be balanced with "don't screw up the revision history, people >>>use it". It's one thing to reformat code that is unreadable, for the most >>>part this code didn't come close to unreadable. >> >>Devil's advocate: >>Then perhaps the (revision control) tool is getting in the way of doing >>the job and should be fixed? :) >>Perhaps being able to flag a changeset as a 'formatting change', and >>have the option to hide it or make it 'transparent' in some fashion? >>Hmm... "Annotate only the changes that relate to feature X."... >>Oh, and a complete AI with that if you don't mind. ;) >> >>But you've probably already thought about all this... > > > Indeed I have.
Figured. :)
> And there is a reason that we have a policy at BitMover > where "formatting changes" are prohibited and we make people redo their > changesets until they get them right.
Ah yes, I do see the value of enforcing a coding style from the get-go.
> In other words, you are welcome to write a revision control system > which can look through the formatting changes and give you the semantic > knowledge that you want. We'd love to see how it is done and then do > it in BitKeeper :)
<troll>What?! And _copy_ someone else's hard work?!</troll> *cough* (Sorry, couldn't resist. ;) )
Eli --------------------. "If it ain't broke now, Eli Carter \ it will be soon." -- crypto-gram eli.carter(a)inet.com `-------------------------------------------------
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |