Messages in this thread | | | Date | Tue, 12 Aug 2003 03:39:36 +0100 | From | Matthew Wilcox <> | Subject | Re: C99 Initialisers |
| |
On Mon, Aug 11, 2003 at 07:18:53PM -0700, Robert Love wrote: > Convert GNU-style to C99-style. I think converting unnamed initializers > to named initializers is a Good Thing, too.
By and large ... here's a counterexample:
static struct pci_device_id tg3_pci_tbl[] __devinitdata = { { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5700, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL }, { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_TIGON3_5701, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0UL }, ...
I don't think anyone would appreciate you converting that to:
static struct pci_device_id tg3_pci_tbl[] __devinitdata = { { .vendor = PCI_VENDOR_ID_BROADCOM, .device = PCI_DEVICE_ID_TIGON3_5700, .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, .class = 0, .class_mask = 0, .driver_data = 0, }, { .vendor = PCI_VENDOR_ID_BROADCOM, .device = PCI_DEVICE_ID_TIGON3_5701, .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, .class = 0, .class_mask = 0, .driver_data = 0, }, ...
Not unless they're paid by the line ;-)
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |