Messages in this thread | | | Date | Mon, 11 Aug 2003 13:45:30 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Remove useless assertions from reiserfs |
| |
Why are these useless?
davej@redhat.com wrote: > diff -urpN --exclude-from=/home/davej/.exclude bk-linus/fs/reiserfs/hashes.c linux-2.5/fs/reiserfs/hashes.c > --- bk-linus/fs/reiserfs/hashes.c 2003-04-10 06:01:29.000000000 +0100 > +++ linux-2.5/fs/reiserfs/hashes.c 2003-07-13 06:04:57.000000000 +0100 > @@ -90,10 +90,6 @@ u32 keyed_hash(const signed char *msg, i > > if (len >= 12) > { > - //assert(len < 16); > - if (len >= 16) > - BUG(); > - > a = (u32)msg[ 0] | > (u32)msg[ 1] << 8 | > (u32)msg[ 2] << 16|
Seems like a valid check to me...
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |