Messages in this thread | | | Date | Mon, 11 Aug 2003 18:57:42 +0200 | From | Mikael Pettersson <> | Subject | Re: [PATCH] Disable APIC on reboot. |
| |
Dave Jones writes: > On Mon, Aug 11, 2003 at 06:29:21PM +0200, Mikael Pettersson wrote: > > I agree we should probably disable the local APIC at reboot if we > > enabled it previously, but this patch is broken. CONFIG_X86_LOCAL_APIC > > doesn't imply that the CPU actually has one, and even if it does, the > > access method may be different (e.g. P5 vs P6/K7/P4, and who knows how > > the future C3 with local APIC will do it). > > Ok. The original poster mentioned that disable_local_apic() didn't > do the right thing there, hence the duplication, so making that DTRT > may make sense ?
I'd have to check what callers expect from disable_local_APIC(), but having it or a new function do a complete disable seems reasonable.
detect_init_APIC() needs to record whether it did a hard enable via APIC_BASE or not, and the complete-disable code needs to check this before accessing APIC_BASE. That + a cpu_has_apic check should do it.
I'll do a patch this evening if no-one else beats me to it.
/Mikael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |