Messages in this thread | | | Date | Sun, 10 Aug 2003 16:10:53 +0200 | From | Pascal Brisset <> | Subject | Re: [PATCH] loop: fixing cryptoloop troubles. |
| |
Fruhwirth Clemens writes: > In loop_transfer_bio the initial vector has been computed only once. For any > situation where more than one bio_vec is present the initial vector will be > wrong. Here is the trivial but important fix.
Looks good, but: - I doubt this could explain the alteration pattern (1 byte every 512). - Corruption also occured with cipher_null (which ignores the IV).
I just noticed a related thread: http://lkml.org/lkml/2003/8/6/313 ("Device-backed loop broken in 2.6.0-test2?")
A side note: Doesn't crypto/crypto_null.c need this fix ?:
static void null_encrypt(void *ctx, u8 *dst, const u8 *src) -{ } +{ memmove(dst, src, NULL_BLOCK_SIZE); } static void null_decrypt(void *ctx, u8 *dst, const u8 *src) -{ } +{ memmove(dst, src, NULL_BLOCK_SIZE); }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |