Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 10 Aug 2003 21:03:22 +0900 (JST) | Subject | Re: [PATCH 7/9] convert drivers/scsi to virt_to_pageoff() | From | YOSHIFUJI Hideaki / 吉藤英明 <> |
| |
In article <20030810045121.31ef7ccc.davem@redhat.com> (at Sun, 10 Aug 2003 04:51:21 -0700), "David S. Miller" <davem@redhat.com> says:
> On Sun, 10 Aug 2003 12:31:48 +0100 > Christoph Hellwig <hch@infradead.org> wrote: > > > You probably want to use pci_map_single here instead.. > > I don't think it's wise to mix two changes at once. Let's get > the straightforward "obvious" shorthand change in, then we can > add your enhancement.
Agreed.
BTW, drivers/scsi/3w-xxxx.c says:
1.02.00.029 - Add missing pci_free_consistent() in tw_allocate_memory(). Replace pci_map_single() with pci_map_page() for highmem. Check for tw_setfeature() failure.
Have problems in pci_map_single() with highmem already gone away?
-- Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org> GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |