Messages in this thread | | | Date | Fri, 4 Jul 2003 01:44:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH] cryptoloop |
| |
Jari Ruusu <jari.ruusu@pp.inet.fi> wrote: > > Changing transfer function prototype may be a tiny speed improvement for one > implementation that happens to use unoptimal API, but at same time be tiny > speed degration to other implementations that use more saner APIs. I am > unhappy with that change, because I happen to maintain four such transfers > that would be subject to tiny speed degration.
Both the source and dest pages are being mapped with a sleeping kmap() at present. This way we can stop doing that, which is a significant saving on highmem and a more significant saving on SMP highmem. (crypto uses kmap_atomic).
Why is the loop driver taking a copy of all the pages btw? Looks to me that we can just clone the bio and save an entire copy?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |