Messages in this thread | | | Date | Thu, 31 Jul 2003 10:51:02 -0700 | From | Greg KH <> | Subject | Re: [PATCH] reorganize USB submenu's |
| |
On Thu, Jul 31, 2003 at 10:11:44AM -0700, Stephen Hemminger wrote: > The USB configuration menu's in 2.6 are a mismash of sub-menu's and comments. > This patch tries to rationalize it so it comes out looking more like the current > filesystems menus. > > I think it is easier to navigate, there should be no functional change from this. > Though some elements may appear/disappear differently based on earlier choices. > > diff -Nru a/drivers/usb/Kconfig b/drivers/usb/Kconfig > --- a/drivers/usb/Kconfig Thu Jul 31 10:07:11 2003 > +++ b/drivers/usb/Kconfig Thu Jul 31 10:07:11 2003 > @@ -44,18 +44,15 @@ > > source "drivers/usb/class/Kconfig" > > -source "drivers/usb/storage/Kconfig" > - > source "drivers/usb/input/Kconfig" > > +source "drivers/usb/storage/Kconfig" > + > source "drivers/usb/image/Kconfig" > > source "drivers/usb/media/Kconfig" > > source "drivers/usb/net/Kconfig" > - > -comment "USB port drivers" > - depends on USB > > config USB_USS720 > tristate "USS720 parport driver" > diff -Nru a/drivers/usb/class/Kconfig b/drivers/usb/class/Kconfig > --- a/drivers/usb/class/Kconfig Thu Jul 31 10:07:11 2003 > +++ b/drivers/usb/class/Kconfig Thu Jul 31 10:07:11 2003 > @@ -1,9 +1,6 @@ > # > # USB Class driver configuration > # > -comment "USB Device Class drivers" > - depends on USB > -
Why remove these seperators? They seem to be useful, as they were added to help remove the clutter we have.
> -menuconfig USB_GADGET > +menu "USB Gadgets" > + depends on USB!=n > + > +config USB_GADGET > tristate "Support for USB Gadgets" > - depends on EXPERIMENTAL > + depends on USB && EXPERIMENTAL
Nope, USB_GADGET does not depend on USB at all.
> -menu "USB HID Boot Protocol drivers" > - depends on USB!=n && USB_HID!=y > > config USB_KBD > tristate "USB HIDBP Keyboard (simple Boot) support" > - depends on USB && INPUT > + depends on USB && INPUT && USB_HIDINPUT=n
Nope, I can build USB_KBD and USB_HIDINPUT as modules at the same time. This breaks that ability.
> config USB_MOUSE > tristate "USB HIDBP Mouse (simple Boot) support" > - depends on USB && INPUT > + depends on USB && INPUT && USB_HIDINPUT=n
Same thing here.
> -comment "USB Multimedia devices" > - depends on USB > +menu "USB Multimedia devices"
I don't really see a nest of menu options as a better option from the separators we have today. But that's just my opinion :)
> -comment "USB Miscellaneous drivers" > - depends on USB > +menu "USB Miscellaneous drivers" > + depends on USB!=n
Why "USB!=n" What's wrong with just "depends on USB"?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |