Messages in this thread | | | Date | Wed, 30 Jul 2003 13:27:49 +0100 | From | Philip Graham Willoughby <> | Subject | Re: PATCH : LEDs - possibly the most pointless kernel subsystemever |
| |
On 2003-07-30 14:06:43 +0000, Ghozlane Toumi wrote: > > I would have thought that leds are output? Why would output devices be > > integrated into the input subsystem? > > Perhaps because the input subsystem could/should be renamed to event > subsytem ?
The LED devices I'm using are nothing like any of the devices in the input subsystem at all -- they don't generate events _ever_ for instance. /dev/input/event## for a pure LED device would be rather boring.
IMO it's cleaner to have a LED subsystem and proxy drivers to expose LEDs provided by other subsystems to the generic interface, rather than trying to ram everything onto the input subsystem regardless of how well it fits.
Of course, other opinions may (will) differ ;-).
If you did want to get the LED change events from the LED subsystem through the input layer, you could add a hook into led_set_real in leds.c, but since all changes are software triggered I don't really see the value in that.
Regards,
Philip Willoughby
Systems Programmer, Department of Computing, Imperial College, London, UK -- echo bzidd@nfo.ho.co.se | tr "bizndfohces" "pwgd9ociaku" Why reinvent the wheel? Because we can make it rounder... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |