Messages in this thread | | | Date | Thu, 3 Jul 2003 19:22:26 -0700 | From | Greg KH <> | Subject | Re: [PATCH] [7/6] PCI config space in sysfs |
| |
On Fri, Jul 04, 2003 at 02:31:31AM +0100, Matthew Wilcox wrote: > On Thu, Jul 03, 2003 at 09:42:58PM +0100, Matthew Wilcox wrote: > > - Fix a couple of bugs in sysfs's handling of binary files (my fault). > > Now I'm having second thoughts. Sigh ;-)
Bleah, right after I sent these patches off :(
> My intended design was that sysfs would copy to/from buffer + offset > rather than buffer. Seems that change 1.6 to this file (hm, bkweb seems > broken at the moment?) changed that. so that broke my pci-sysfs changes > which weren't in the tree at the time. > > It probably makes more sense to copy to/from buffer rather than > buffer+offset so we can implement larger sized binary files (we can use > a smaller buffer than the size of the file and do multiple read/write > calls). > > So I think I'd like to hold off on this patchset, not change sysfs and > adapt my changes to the new API (which I didn't even know had changed. > grr.)
Ok, want to send a patch to backout only the api changes that you made?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |