Messages in this thread Patch in this message | | | Date | Mon, 28 Jul 2003 15:11:04 -0700 | From | "Randy.Dunlap" <> | Subject | Re: Assorted 2.6.0-test2 build warnings |
| |
On Sun, 27 Jul 2003 20:57:31 -0400 "J.C. Wren" <jcwren@jcwren.com> wrote:
| Assorted warnings building 2.6.0-test2, on an Athlon: | | CC fs/ntfs/super.o | fs/ntfs/super.c: In function `is_boot_sector_ntfs': | fs/ntfs/super.c:375: warning: integer constant is too large for "long" type
Please see if the patch below fixes this one.
| CC fs/smbfs/ioctl.o | fs/smbfs/ioctl.c: In function `smb_ioctl': | fs/smbfs/ioctl.c:36: warning: comparison is always false due to limited range of data type | fs/smbfs/ioctl.c:36: warning: comparison is always false due to limited range of data type | fs/smbfs/ioctl.c:36: warning: comparison is always false due to limited range of data type | fs/smbfs/ioctl.c:36: warning: comparison is always false due to limited range of data type
Hm, appears to be on NEW_TO_OLD_UID(server->mnt->mounted_uid) to me. mounted_uid is of type __kernel_uid_t, which is unsigned short on i386, so NEW_TO_OLD_UID() is rather useless on it. Should mounted_uid be __kernel_uid32_t instead?
| CC drivers/char/vt_ioctl.o | drivers/char/vt_ioctl.c: In function `do_kdsk_ioctl': | drivers/char/vt_ioctl.c:85: warning: comparison is always false due to limited range of data type | drivers/char/vt_ioctl.c:85: warning: comparison is always false due to limited range of data type
Yes, line 85 is useless as it is.
What -W (?) options are you compiling with? I'm not seeing these.
| drivers/char/vt_ioctl.c: In function `do_kdgkb_ioctl': | drivers/char/vt_ioctl.c:211: warning: comparison is always false due to limited range of data type
Another unsigned char compared to value > 255.
| CC drivers/char/keyboard.o | drivers/char/keyboard.c: In function `k_fn': | drivers/char/keyboard.c:665: warning: comparison is always true due to limited range of data type
Right, same as above.
| CC drivers/video/matrox/matroxfb_g450.o | drivers/video/matrox/matroxfb_g450.c: In function `g450_compute_bwlevel': | drivers/video/matrox/matroxfb_g450.c:129: warning: duplicate `const' | drivers/video/matrox/matroxfb_g450.c:130: warning: duplicate `const'
| AS arch/i386/boot/setup.o | arch/i386/boot/setup.S: Assembler messages: | arch/i386/boot/setup.S:165: Warning: value 0x37ffffff truncated to 0x37ffffff
Interesting. How do I make this happen on my system?
Are you using some old (or new) version of gcc/gas or what?
-- ~Randy
patch_name: ntfs_ulong.patch patch_version: 2003-07-28.14:29:57 author: Randy.Dunlap <rddunlap@osdl.org> description: make a constant be UL; product: Linux product_versions: 2.6.0-test2 maintainer: Anton Altaparmakov <aia21@cantab.net> diffstat: = fs/ntfs/layout.h | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
diff -Naurp ./fs/ntfs/layout.h~type ./fs/ntfs/layout.h --- ./fs/ntfs/layout.h~type 2003-07-27 10:02:48.000000000 -0700 +++ ./fs/ntfs/layout.h 2003-07-28 14:05:20.000000000 -0700 @@ -43,7 +43,7 @@ #define const_cpu_to_le64(x) __constant_cpu_to_le64(x) /* The NTFS oem_id */ -#define magicNTFS const_cpu_to_le64(0x202020205346544e) /* "NTFS " */ +#define magicNTFS const_cpu_to_le64(0x202020205346544eUL) /* "NTFS " */ /* * Location of bootsector on partition: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |