Messages in this thread | | | Date | Mon, 28 Jul 2003 12:54:49 -0700 | From | Andrew Morton <> | Subject | Re: PATCH: fix 2 byte data leak due to padding |
| |
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > On Llu, 2003-07-28 at 04:49, Lou Langholtz wrote: > > >+ memset(&tmp, 0, sizeof(struct __old_kernel_stat)); > > > > > Wouldn't it be more clear (better) to use sizeof(tmp) here rather than > > sizeof(struct _old_kernel_stat)? > > sizeof(variable) can be suprising some times so I always use sizeof(type) out > of habit. (Think sizeof(x) when X later becomes a pointer)
#define memzero(addr) memset(addr, 0, sizeof(*addr))
would robustify a lot of these things...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |