Messages in this thread | | | Date | Sun, 27 Jul 2003 23:21:34 +0200 | From | Manuel Estrada Sainz <> | Subject | Re: [PATCH] Re: Firmware loading problem |
| |
On Sun, Jul 27, 2003 at 08:21:11PM +0100, Matthew Wilcox wrote: > On Sat, Jul 26, 2003 at 11:04:58AM +0200, Manuel Estrada Sainz wrote: > > - hopefully adapt drivers/pci/pci-sysfs.c to this changes > > - Please double check, I didn't look very carefully on > > this. > > Definitely wrong. I was going to undo this change since I realised how > it doesn't work for you; but the change you made to the PCI code is wrong. > It ends up copying everything to offset 0 from the buf address.
Exactly, and that is what sysfs code expects (with the rest of the patch), the buffer is just temporary storage, it doesn't really matter what offset you use as long as you don't write further than buffer+PAGE_SIZE and both sides of the issue agree.
> I wish Pat had cc'd me when making the change to the interface > originally ;-( > > I'll whip up a patch in a few minutes.
Great.
Have a nice day
Manuel -- --- Manuel Estrada Sainz <ranty@debian.org> <ranty@bigfoot.com> <ranty@users.sourceforge.net> ------------------------ <manuel.estrada@hispalinux.es> ------------------- Let us have the serenity to accept the things we cannot change, courage to change the things we can, and wisdom to know the difference. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |