Messages in this thread | | | Date | Wed, 2 Jul 2003 09:59:51 +0100 | From | Joe Thornber <> | Subject | Re: [RFC 3/3] dm: v4 ioctl interface |
| |
On Tue, Jul 01, 2003 at 03:05:07PM -0500, Kevin Corry wrote: > The "unregister" call needs to be before the actual rename. Same patch as a > couple weeks ago.
Agreed.
> > +static int check_name(const char *name) > > +{ > > + if (strchr(name, '/')) { > > + DMWARN("invalid device name"); > > + return -EINVAL; > > + } > > + > > + return 0; > > +} > > Can't we allow slashes in device names? I thought we discussed this before > (http://marc.theaimsgroup.com/?t=104628092700011&r=1&w=2). Any reason for the > change?
I think I made the wrong decision before. Still thinking about it though.
> Does this imply that if the dm_swap_table() call fails, then the "inactive" > mapping is automatically deleted?
Yes, that is the behaviour ATM. Would you rather it didn't ?
> As a side note, the __bind() function in dm.c currently will never return an > error, so dm_swap_table() doesn't necessarily need to check for one.
y, __bind can become void.
- Joe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |