Messages in this thread | | | Date | Thu, 17 Jul 2003 13:19:02 -0700 | From | "David S. Miller" <> | Subject | Re: SET_MODULE_OWNER |
| |
On Thu, 17 Jul 2003 16:22:33 -0400 Jeff Garzik <jgarzik@pobox.com> wrote:
> This change is a major behavior change. The whole point of removing a > module is knowing its gone ;-) And that is completely changed now. > Modules are very often used by developers in a "modprobe ; test ; rmmod" > cycle, and that's now impossible (you don't know when the net device, > and thus your code, is really gone). It's already breaking userland, > which does sweeps for zero-refcount modules among other things. > > I can't believe I missed this.
Umm, Jeff, for years if you rmmod netfilter it very will do this for you even if you have firewall rules installed. This behavior exists in all of 2.4.x
People who do modprobe -r in their crontabs are asking for trouble, losing their netdevice is the least of their trouble especially if they have firewall rules installed.
Module reference counting added complications to net device handling, and once I killed it off we could begin addressing all of the real bugs that exist with network devices. For example, now that we're foreced to make net devices dynamic memory in all cases we can deal with dangling procfs/sysfs references to the device sanely. Fixing that was not possible with module refcounting.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |