Messages in this thread | | | Date | Sun, 13 Jul 2003 21:04:09 +0100 | From | Matthew Wilcox <> | Subject | Re: do_div vs sector_t |
| |
On Sun, Jul 13, 2003 at 09:14:35PM +0200, Bernardo Innocenti wrote: > On Sunday 13 July 2003 19:26, Richard Henderson wrote: > > On Fri, Jul 11, 2003 at 11:33:59PM +0100, Matthew Wilcox wrote: > > > Better ideas? > > > > if (likely(((n) >> 31 >> 1) == 0)) { > > Do we still need to fix this? I've already posted a patch to disallow > calling do_div() with any divisor that doesn't look like an unsigned > 64bit interger.
No, I think the combination of sector_div() and your patch makes everything happy-happy. Thanks!
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |