Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 10 Jul 2003 11:45:58 -0700 | From | Chris Wright <> | Subject | Re: [PATCH] add seq file helpers from 2.5 (fwd) |
| |
* Chris Wright (chris@wirex.com) wrote: > * Marcelo Tosatti (marcelo@conectiva.com.br) wrote: > > +int single_open(struct file *file, int (*show)(struct seq_file *, void*), void *data) > > +{ > > + struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL); > > + int res = -ENOMEM; > > + > > + if (op) { > > + op->start = single_start; > > + op->next = single_next; > > + op->stop = single_stop; > > + op->show = show; > > + res = seq_open(file, op); > > Any reason not to simply allocate static ops struct? As in:
Bah, nevermind, I didn't look closely enough to see that show is dynamic here (not to mention it is simple straight backport). Sorry for senseless noise ;-)
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |