Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 5 Jun 2003 01:49:33 -0700 | From | Greg KH <> | Subject | Re: [BK PATCH] PCI and PCI Hotplug changes and fixes for 2.5.70 |
| |
On Thu, Jun 05, 2003 at 09:38:15AM +0100, Dave Jones wrote: > On Wed, Jun 04, 2003 at 07:14:52PM -0700, Greg KH wrote: > > > > p.s. I'll send these as patches in response to this email to lkml for > > > those who want to see them. > > > > I don't think everyone really wants to see all 63 different > > pci_for_each_dev() removal patches > > I'm puzzled why you did.. > > - pci_for_each_dev(device) > + while ((device = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, device)) != NULL) > > when you could have just added whatever locking pci_find_device() does > to pci_for_each_dev() You'd then not have had to touch any of these > drivers, and it'd look a damn sight better to look at IMO.
pci_for_each_dev() is currently a macro, not a function, and I'm trying to get rid of all public access to the pci lists. The majority of pci drivers use the pci_find_device() function in just the way that I converted the few remaining users of pci_for_each_dev() to (yeah, "few" is a relative number, but check out how many people call pci_find_device()...)
I guess I could create this to clean it up a bit: #define pci_find_all_devices(dev) pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)
but that's really not that much of a change...
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |