Messages in this thread | | | Date | Mon, 30 Jun 2003 17:31:01 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] ethtool_ops |
| |
(sorry for the delayed reply; PCI domain work got a lot more important for a while)
On Fri, Jun 06, 2003 at 01:17:46PM -0700, Feldman, Scott wrote: > * On get_gregs, for example, would it make sense to ->get_drvinfo > so you'll know regdump_len and therefore can kmalloc an ethtool_regs > with enough space to pass to ->get_regs? Keep the kmalloc and > kfree together. Same for self_test, get_strings, and get_stats. > For get_strings, size = max{n_stats, testinfo_len)*sizeof(u64).
That would be one possibility, but get_drvinfo is quite heavyweight. I think I'd prefer to not do that unless there's a strong feeling about thing.
> * If the above is done, can we have one function type for the > ethtool_ops > functions? int f(struct netdev *, struct ethtool_cmd *). The > drawback is the driver needs to cast to the specific ethtool_* struct.
Definitely not -- the point is adding type safety.
> * Can we get an HAVE_ETHTOOL_OPS defined in netdevice.h to support > backward compat?
I'm hoping to avoid that by getting compatibility code merged into 2.4.22.
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |