Messages in this thread | | | Date | Sun, 29 Jun 2003 21:34:50 +0100 | From | Russell King <> | Subject | Re: [PATCH] Fix mtdblock / mtdpart / mtdconcat |
| |
On Wed, Jun 25, 2003 at 01:43:09PM +0100, David Woodhouse wrote: > On Mon, 2003-06-23 at 01:00, Russell King wrote: > > Dirtily disable ECC support; it doesn't work when mtdpart is layered > > on top of mtdconcat on top of CFI flash. > > > > There is probably a better fix, but that's for someone else to find. > > I had to run 'indent' on mtdconcat.c before I could stand to even look > for it, so I haven't attached the patch here -- but could you try v1.6 > from CVS, which should refrain from pretending to have ecc/oob access > functions of none of the subdevices have them, and hence fix the problem > you observed.
While looking over the changes between 1.5 and 1.6, I spotted this. You may want to fix this change:
- concat->mtd.eccsize != subdev[i]->eccsize) { + concat->mtd.eccsize != subdev[i]->eccsize || + !concat->mtd.read_ecc != !concat->mtd.read_ecc || + !concat->mtd.write_ecc != !concat->mtd.write_ecc || + !concat->mtd.read_oob != !concat->mtd.read_oob || + !concat->mtd.write_oob != !concat->mtd.write_oob) {
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |