Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 19 Jun 2003 14:20:10 +0200 | From | Jens Axboe <> | Subject | Re: Regarding drivers/ide/ide-cd.c in 2.5.72 |
| |
On Tue, Jun 17 2003, Andy Polyakov wrote: > Hi, > > I have brought this issue once already in 2.5.70 context (see uppermost > post in http://marc.theaimsgroup.com/?t=105410790500005&r=1&w=2), but it > apparently slipped through. So I've decided to bring it up again, this > time describing [hopefully] better how does this *generic* problem with > ide-cd.c manifests itself. In the nutshell the problem is that [as it is > now] every failed SG_IO request is replayed second time without data > transfer. E.g. if WRITE(10) SCSI command fails with sense code X, ide-cd > immediately resends the command block descriptor one more time, this time > without programming for any associated I/O payload, which [normally] > results in *different* sense code. And the catch is that user-land gets > this second sense code instead of the real/original one. Suggested patch > overcomes this problem by immediately purging the failed SG_IO request > from the request queue.
Patch looks fine, care to resend actually trying to follow the style in the file in question?
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |