Messages in this thread | | | Subject | Re: [RFC][PATCH] CONFIG_NR_CPUS for 2.4.21 | From | Robert Love <> | Date | 18 Jun 2003 18:04:34 -0700 |
| |
On Wed, 2003-06-18 at 16:01, J.A. Magallon wrote:
> Oops, credits for this should go to (and possible comments/reject come > from) Andrew Morton <akpm@zip.com.au>, Robert Love <rml@tech9.net>
It looks fine to me, although I do not think this is as critical an issue as it was for 2.5, because the per-processor bloat is not nearly as bad in 2.4 as 2.5. Nonetheless, this does not actually break anything.
Except, I notice in some places (namely, 64-bit architectures), you set the default NR_CPUS value to 64. While this ought to work if sizeof(unsigned long)==8, it might not and is probably not a change we want in a stable series. The default should be 32 all around.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |