lkml.org 
[lkml]   [2003]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH CYCLADES 1/2] fix cli()/sti() for ISA Cyclom-Y boards
On Wed, Jun 18, 2003 at 05:48:17PM -0400, John Stoffel wrote:

> - save_flags(flags); cli();
> + spin_lock_irqsave(&isa_card_lock, flags);
>
> if ((e1 = tty_unregister_driver(cy_serial_driver)))
> printk("cyc: failed to unregister Cyclades serial driver(%d)\n",
> e1);
>
> - restore_flags(flags);
> + spin_unlock_irqrestore(&isa_card_lock,flags);

It doesn't fix the problem and only makes the compile trouble go away.
Not to mention anything else, you are relying on a lot of code being
non-blocking.

Could you explain what is protected by disabling interrupts and taking
a spinlock here?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.021 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site