Messages in this thread | | | Subject | Re: [PATCH] 2.5.72 O(1) interactivity bugfix | From | Robert Love <> | Date | 18 Jun 2003 11:05:05 -0700 |
| |
On Wed, 2003-06-18 at 07:43, Con Kolivas wrote:
> While messing with the interactivity code I found what appears to be an > uninitialised variable (p->sleep_avg), which is responsible for all the > boost/penalty in the scheduler.
The variable isn't uninitialized, it is inherited from the parent.
Recall that the task_struct of the new child starts off as a duplicate of the parent's. If the variables are not explicitly set, they remain the same as the parent's.
So this patch ends up resetting the sleep_avg to zero, instead of being the same as the parent, which may or may not result in better performance.
Robert Love
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |