Messages in this thread | | | Date | Tue, 17 Jun 2003 17:06:58 -0700 | From | Frank Cusack <> | Subject | Re: [PATCH] nfs_unlink() again, and trivial nfs_fhget |
| |
On Tue, Jun 17, 2003 at 04:55:07PM -0700, Frank Cusack wrote: > On Tue, Jun 17, 2003 at 11:41:18AM -0700, Trond Myklebust wrote: > > If you think that code is wrong then make an argument for > > changing it, and send me a patch. > > I did make an argument, and did send you a patch. Please see my email > with message id <20030611002226.A19078@google.com>.
Let me quickly amend that, the referenced message is also a VFS change, but a worse one than proposed in this thread. The reason I proposed to do it in the VFS is that I couldn't get it to work in the NFS code.
After returning from nfs_rename(), I'd promptly get a null pointer deref.
Yes, I did want to suggest an NFS patch, but it became clear that after the VFS calls ->rename, it expects things to happen which I didn't do. More specifically, I avoided the 'if (!d_unhashed()) d_drop()' code, and rather than figure out the requirements I simply figured I'd propose a VFS change. Simple just seemed good to me ... I don't think it's so bad for the VFS to have *small* bits of fs-specific knowledge. You could call the flag (say) DCACHE_DONT_UNLINK if it makes it sound less specific.
/fc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |