lkml.org 
[lkml]   [2003]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][2.5.71] x86-64 apic/nmi cleanups
On Mon, Jun 16, 2003 at 05:11:41PM +0200, mikpe@csd.uu.se wrote:
> Andi,
>
> The driver model conversion left x86-64's apic.c and nmi.c with
> obsolete #includes and comments, and some poor code formatting.

Most of this is already in the patchkit.

>
> nmi.c also lacks the 'nmi_pm_active' change which went into
> i386 recently. It's needed to prevent enabling the watchdog
> after resume if it was disabled before suspend: this happens
> if another driver has claimed the HW and disabled the watchdog.
> This won't hit until you remove the #if 0 in lapic_nmi_resume(),
> however. (Why do you need that?)

I think it came from Pavel. I will remove it for now and merged that
change.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.036 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site