Messages in this thread | | | Date | Mon, 16 Jun 2003 11:49:11 +0200 | From | DervishD <> | Subject | Re: [RESEND][PATCH] against mmap.c (do_mmap_pgoff) and a note |
| |
* Jörn Engel <joern@wohnheim.fh-wedel.de> dixit: > > - if (!len) > > + if (len == 0) > No change.
Just cosmethic, ask Dave S. Miller, he is the author of the change, I'm just doing the patch for him.
> > return addr; > > > > - if (len > TASK_SIZE) > > - return -EINVAL; > > - > > len = PAGE_ALIGN(len); > > > > + if (len > TASK_SIZE || len == 0) > > + return -EINVAL; > > + > > PAGE_ALIGN(0) = 0 > PAGE_ALIGN(1) = PAGE_SIZE > > Again, no change.
There is a change in archs where TASK_SIZE is the entire addressable space (like sparc64). Ask Dave S., again. The problem did arise when TASK_SIZE is ~0. Then semantics change.
Raúl Núñez de Arenas Coronado
-- Linux Registered User 88736 http://www.pleyades.net & http://raul.pleyades.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |