Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 16 Jun 2003 11:41:49 -0700 | From | Greg KH <> | Subject | Re: [RFC][2.5] list_for_each_safe not so safe (was Re: OOPS w83781d during rmmod (2.5.70-bk1[1234])) |
| |
On Sat, Jun 14, 2003 at 08:26:35AM +0200, Martin Schlemmer wrote: > On Fri, 2003-06-13 at 04:36, Mark M. Hoffman wrote: > > > > > Anyhow, Only change I have made to the w83781d driver, is one line > > > > > (just tell it to that if the chip id is 0x72, its also of type > > > > > w83726HF), but now (2.5.70-bk1[123]) it segfaults for me on rmmod, where > > > > > it did not with 2.5.68 kernels when I still had the other board. I will > > > > > attach a oops tomorrow or such when I get home. > > > > > > > My first patch was naive; the patch below solves the problem by > > letting w83781d_detach_client remove the three clients (1 * primary > > + 2 * subclients) independently. It's a noisy patch because I had > > to change the way the subclients were kmalloc'ed - sorry. The meat > > is around line 1422. This patch works for me... comments? > > > > Regards, > > > > --- > > Mark M. Hoffman > > mhoffman@lightlink.com > > Greg, this patch from Mark fixes it, please include in your stuff > to send to Linus.
Applied, thanks.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |