Messages in this thread | | | Date | Fri, 13 Jun 2003 10:19:43 -0700 | From | Patrick Mansfield <> | Subject | Re: [PATCH] Re: scsi_add_device() broken? (was Re: SBP2 hotplug doesn't update /proc/partitions) |
| |
On Fri, Jun 13, 2003 at 12:08:12PM -0400, Ben Collins wrote:
> Here's the scenario. scsi_add_lun doesn't set sdp->devfs_name before > calling scsi_register_device(). Since scsi_register_device calls down to > things like sd_probe, which do try to use sdp->devfs_name, things fail. > > Just an easy change, moving the sdp->devfs_name creation before calling > scsi_register_device(). Patch fixes this.
It really needs to move into the caller of scsi_add_lun, so we setup all the other fields, and possibly call scsi_unlock_floptical before registering.
And the return value should be checked - then on failure just set res (in scsi_probe_and_add_lun) so it is cleaned up.
-- Patrick Mansfield - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |