Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: ioctl cleanups: enable sg_io and serial stuff to be shared | Date | Fri, 9 May 2003 01:35:39 +0200 |
| |
On Friday 09 May 2003 01:03, Pavel Machek wrote:
> > Suggest something sane like defining a macro such as > > "compat_task(tsk)" that can be tested by various bits of > > code. > > That makes more sense. Unfortunately, that means that case "okay, it > is compatible" can not be told from "we did not bother to check > compat_task()". :-(. Nor do I see a transition phase.
You still need to list them as COMPATIBLE_IOCTL() or call register_ioctl32_conversion(IOCTLNO, 0) when the ioctl has been made compatible. Unless we are sure that every single ioctl has been made compatible (probably never), the default must be to call sys_ioctl from compat_sys_ioctl only if the number is explicitly listed. This should solve both problems you mentioned.
One minor remaining problem is that if multiple files contain handlers for the same ioctl number, they have to be converted at the same time because the number can not both be compatible and incompatible at the same time.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |