Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 6 May 2003 21:49:18 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH[[2.5][3-11] update dvb subsystem core |
| |
On Tue, May 06, 2003 at 06:04:00PM +0200, Michael Hunold wrote: > Hello, > > this patch updates the dvb subsystem core. > > Fixed problems: > - partly reintroduced the DVB_DEVFS_ONLY switch, which was previously > wiped out by Alan Cox: if enabled, some really obscure code is not > compiled into the kernel that is necessary to xxx
No, this is wrong. I did remove it not Alan Cox and I removed it because kernel 2.5/2.6 should not behave differently whether devfs is used or not except nodes showing up in devfs.
> - /* fixme: is this correct? */ > - try_module_get(THIS_MODULE); > +
Just removing this makes the code even more incorrect. You need to add a ->owner member and call try_module_get on it before calling into the module (and handle the return value..)
> -typedef struct dmxdev_dvr_s { > +typedef struct dmxdev_dvr { > int state; > - struct dmxdev_s *dev; > + struct dmxdev *dev; > dmxdev_buffer_t buffer; > } dmxdev_dvr_t;
Once you rename everything you can nuke the typedef crap aswel..
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |