lkml.org 
[lkml]   [2003]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: Linux 2.4.21-rc3, writing to /dev/console returns ESPIPE
On Sun, May 25, 2003 at 12:22:14PM +0100, Mitch@0Bits.COM wrote:
> The checkin on linux-2.4.21-rc3/drivers/char/tty_io.c
>
> + /* Can't seek (pwrite) on ttys. */
> + if (ppos != &file->f_pos)
> + return -ESPIPE;
>
> should not be there in my opinion.

s/not be/be not/

--- drivers/char/tty_io.c Sat May 17 11:14:02 2003
+++ /tmp/tty_io.c Sun May 25 07:37:37 2003
@@ -751,6 +751,10 @@
struct tty_struct * tty;
struct inode *inode = file->f_dentry->d_inode;

+ /* Can't seek (pwrite) on ttys. */
+ if (ppos != &file->f_pos)
+ return -ESPIPE;
+
/*
* For now, we redirect writes from /dev/console as
* well as /dev/tty0.
@@ -775,10 +779,6 @@
return res;
}
}
-
- /* Can't seek (pwrite) on ttys. */
- if (ppos != &file->f_pos)
- return -ESPIPE;

tty = (struct tty_struct *)file->private_data;
if (tty_paranoia_check(tty, inode->i_rdev, "tty_write"))
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.018 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site