lkml.org 
[lkml]   [2003]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][2.5] generic_usercopy() function (resend, forgot the patches)
From
Date
On Fri, 2003-05-23 at 10:47, Christoph Hellwig wrote:
> > + err = func(inode, file, cmd, parg);
> > + if (err == -ENOIOCTLCMD)
> > + err = -EINVAL;
>
> I don't think this is the right place for this substitution - leave it to
> the drivers.

And make it -ENOTTY. -EINVAL is not correct for unknown ioctls.

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:5.081 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site