Messages in this thread Patch in this message | | | Date | Sat, 24 May 2003 14:06:05 +0200 | From | René Scharfe <> | Subject | Re: [PATCH] SYSV fs: test in sysv_hash() is backwards |
| |
On Sat, 24 May 2003 13:32:13 +0200 René Scharfe <l.s.r@web.de> wrote:
> it seems sysvfs will compute a filename hash only in the case where > that name is too long.
... and that is just fine. On second glance, that is _exactly_ what it should do. The common case is handled in fs/namei.c. D'oh!
There's opportunity for cleanup, though. Updated patch below.
René
--- fs/sysv/namei.c.orig 2003-05-24 12:49:57.000000000 +0200 +++ fs/sysv/namei.c 2003-05-24 13:59:09.000000000 +0200 @@ -42,21 +42,12 @@ static int sysv_hash(struct dentry *dentry, struct qstr *qstr) { - unsigned long hash; - int i; - const unsigned char *name; - - i = SYSV_NAMELEN; - if (i >= qstr->len) - return 0; /* Truncate the name in place, avoids having to define a compare function. */ - qstr->len = i; - name = qstr->name; - hash = init_name_hash(); - while (i--) - hash = partial_name_hash(*name++, hash); - qstr->hash = end_name_hash(hash); + if (qstr->len > SYSV_NAMELEN) { + qstr->len = SYSV_NAMELEN; + qstr->hash = full_name_hash(qstr->name, qstr->len); + } return 0; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |