Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 22 May 2003 17:23:04 -0700 (PDT) | Subject | Re: Error during compile of 2.5.69-mm8 | From | "David S. Miller" <> |
| |
From: Thomas Schlichter <schlicht@uni-mannheim.de> Date: Fri, 23 May 2003 02:13:34 +0200
> Therefore, it was a complete error for anyone else to start using this > macro for other structures. So nobody should better use THIS_MODULE?!
No, it is exactly what they should use.
They should avoid using SET_MODULE_OWNER.
For ME and many other driver developers SET_MODULE_OWNER does not belong to netdevice, it belongs to the module infrastructure! Then by changing SET_MODULE_OWNER you will break source backwards compatability for every single network device driver out there, something I was explicitly trying to avoid.
SET_MODULE_OWNER() is a bogus interface because it is typeless.
Therefore I suggest that you create macros specific to your individual structures, and use these to achieve 2.4.x/2.5.x build compatability in setting the ->owner field of such structs. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |