lkml.org 
[lkml]   [2003]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: arch/i386/kernel/mpparse.c warning fixes
William Lee Irwin III writes:
> diff -prauN mm8-2.5.69-1/arch/i386/kernel/mpparse.c mm8-2.5.69-2/arch/i386/kernel/mpparse.c
> --- mm8-2.5.69-1/arch/i386/kernel/mpparse.c 2003-05-22 04:54:48.000000000 -0700
> +++ mm8-2.5.69-2/arch/i386/kernel/mpparse.c 2003-05-22 08:06:13.000000000 -0700
> @@ -171,7 +171,7 @@ void __init MP_processor_info (struct mp
>
> num_processors++;
>
> - if (m->mpc_apicid > MAX_APICS) {
> + if (MAX_APICS - m->mpc_apicid <= 0) {
> printk(KERN_WARNING "Processor #%d INVALID. (Max ID: %d).\n",
> m->mpc_apicid, MAX_APICS);
> --num_processors;

Eeew. Whatever the original problem is, this "fix" is just too obscure and ugly.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.044 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site