Messages in this thread | | | Date | Wed, 21 May 2003 17:44:56 +1000 | From | David Gibson <> | Subject | Re: request_firmware() hotplug interface, third round and a halve |
| |
On Wed, May 21, 2003 at 12:23:18AM -0700, Greg Kroah-Hartman wrote: > > +struct firmware_priv { > > + char fw_id[FIRMWARE_NAME_MAX]; > > + struct completion completion; > > + struct bin_attribute attr_data; > > + struct firmware *fw; > > + s32 loading:2; > > + u32 abort:1; > > Why s32 and u32? Why not just ints for both of them?
And for that matter, I don't think there's any point using bitfields, 61 bits is not worth it.
-- David Gibson | For every complex problem there is a david@gibson.dropbear.id.au | solution which is simple, neat and | wrong. http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |