Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 02 May 2003 09:47:33 -0700 | From | Dave Hansen <> | Subject | Re: 2.5.68-mm4 |
| |
William Lee Irwin III wrote: >> On Fri, May 02, 2003 at 02:01:49AM -0700, Andrew Morton wrote: >>+dont-set-kernel-pgd-on-PAE.patch >> little ia32 optimisation/cleanup > > It looks like no one listened to my commentary on the set_pgd() patch. > > Remove pointless #ifdef, pointless set_pgd(), and a mysterious line > full of nothing but whitespace after the #endif, and update commentary. > -#ifndef CONFIG_X86_PAE > - set_pgd(pgd, *pgd_k); > -#endif
I wask thinking that the PMD set in 4G mode was a noop. But, it isn't, so it makes up for the completely removed pgd set.
This comment needs to get updated in include/asm-i386/pgtable-2level.h: /* * (pmds are folded into pgds so this doesn't get actually called, * but the define is needed for a generic inline function.) */ #define set_pmd(pmdptr, pmdval) (*(pmdptr) = pmdval) #define set_pgd(pgdptr, pgdval) (*(pgdptr) = pgdval)
-- Dave Hansen haveblue@us.ibm.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |